From 69090c9ac6f5061b4d84a341817f669052ae8fcf Mon Sep 17 00:00:00 2001
From: =?utf8?q?Rapha=C3=ABl=20Jakse?= <raphael.jakse@univ-grenoble-alpes.fr>
Date: Sat, 4 Apr 2020 15:30:01 +0200
Subject: [PATCH] Refactor: handle array responses from the server at one place

---
 trivabble.js | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/trivabble.js b/trivabble.js
index b3ca064..f39d684 100644
--- a/trivabble.js
+++ b/trivabble.js
@@ -491,6 +491,13 @@
     }
 
     function handleReceivedData(data) {
+        if (data instanceof Array) {
+            for (var i = 0; i < data.length; i++) {
+                handleReceivedData(data[i]);
+            }
+            return;
+        }
+
         if (data.msg) {
             chatMessages.appendChild(
                 document.createElement("div")
@@ -735,14 +742,7 @@
                         }
 
                         retriedImmediately = false;
-
-                        if (msgs instanceof Array) {
-                            for (var i = 0; i < msgs.length; i++) {
-                                handleReceivedData(msgs[i]);
-                            }
-                        } else {
-                            handleReceivedData(msgs);
-                        }
+                        handleReceivedData(msgs);
                     } else {
                         break;
                     }
@@ -767,14 +767,7 @@
                 }
 
                 try {
-                    var res = JSON.parse(xhr.responseText);
-                    if (res instanceof Array) {
-                        for (var i = 0; i < res.length; i++) {
-                            handleReceivedData(res[i]);
-                        }
-                    } else {
-                        handleReceivedData(res);
-                    }
+                    handleReceivedData(JSON.parse(xhr.responseText));
                 } catch (e) {
                     fatalError(e);
                 }
-- 
2.30.2