From: Laurent Mazet <mazet@softndesign.org>
Date: Sun, 14 May 2023 21:37:27 +0000 (+0200)
Subject: buggy code (3)
X-Git-Url: https://secure.softndesign.org/git/?a=commitdiff_plain;h=1e0cfbd73b4b4a7b5aa4994f998e824f59c76cef;p=webserver.git

buggy code (3)
---

diff --git a/server.c b/server.c
index 1535ef3..4f3b24f 100644
--- a/server.c
+++ b/server.c
@@ -72,18 +72,24 @@ void terminate_network_context (void)
 
 socket_t open_listening_socket (int port)
 {
+    int val = 1;
+
     VERBOSE (DEBUG, fprintf (stdout, "Opening socket\n"));
-    socket_t sock = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP);
+    //socket_t sock = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP);
+    socket_t sock = socket (AF_INET, SOCK_STREAM, 0);
     if (sock == INVALID_SOCKET) {
         return -1;
     }
 
     struct sockaddr_in addr = {0};
-    addr.sin_family = PF_INET;
+    bzero (&addr, sizeof (addr));
+    //addr.sin_family = PF_INET;
+    addr.sin_family = AF_INET;
     addr.sin_port = htons (port);
     addr.sin_addr.s_addr = htonl (INADDR_ANY);
 
     VERBOSE (DEBUG, fprintf (stdout, "Binding socket\n"));
+    //setsockopt (sock, SOL_SOCKET, SO_REUSEADDR, &val, sizeof (val));
     int rc = bind (sock, (struct sockaddr *)&addr, sizeof (addr));
     if (rc == SOCKET_ERROR) {
         VERBOSE (ERROR, fprintf (stderr, "error: bind %d\n", ERRNO));
@@ -98,7 +104,6 @@ socket_t open_listening_socket (int port)
 #ifndef _WIN32 /* Posix */
     fcntl (sock, F_SETFL, O_NONBLOCK);
 #endif
-    int val = 1;
     rc = setsockopt (sock, IPPROTO_TCP, TCP_NODELAY, (char *)&val, sizeof (val));
     if (rc < 0) {
         VERBOSE (ERROR, fprintf (stderr, "error: %s\n", "setsockopt/TCP_NODELAY"));