From: Laurent Mazet <mazet@softndesign.org>
Date: Tue, 14 Feb 2023 23:30:39 +0000 (+0100)
Subject: fix a memory leak
X-Git-Tag: v1.1~3^2~2
X-Git-Url: https://secure.softndesign.org/git/?a=commitdiff_plain;h=1546a0b59e357985fb0588daf01a8af8ecbd9412;p=calc.git

fix a memory leak
---

diff --git a/tabular.c b/tabular.c
index 83c1789..8100f04 100644
--- a/tabular.c
+++ b/tabular.c
@@ -33,7 +33,9 @@ tab_t *resize_tab (tab_t *tab, int nb)
         tmp = (double *) callocordie (nb, sizeof (double));
         memcpy (tmp, tab->data, ((tab->size < nb) ? tab->size : nb) * sizeof (double));
     }
-    free (tab->data);
+    if (tab->data){
+        free (tab->data);
+    }
     tab->data = tmp;
     tab->size = nb;
     return tab;
@@ -134,11 +136,13 @@ double pop_tab (tab_t *tab, int id)
     if ((!tab) || (((id < 1) || (id > tab->size)) && (id != -1))) {
         VERBOSE (WARNING, fprintf (stdout, "error out of bounds (%d/%d)\n", id, (tab) ? tab->size : 0));
     } else {
-        ret = tab->data[id - 1];
 
         /* special case for inserting an element at the end */
         id = (id == -1) ? tab->size : id;
 
+        /* read data */
+        ret = tab->data[id - 1];
+
         /* create larger tab */
         double *tmp = (double *) callocordie (tab->size - 1, sizeof (double));
         memcpy (tmp, tab->data, (id - 1) * sizeof (double));