correct bound checking
authorLaurent Mazet <mazet@softndesign.org>
Wed, 28 Apr 2021 20:40:47 +0000 (22:40 +0200)
committerLaurent Mazet <mazet@softndesign.org>
Wed, 28 Apr 2021 20:40:47 +0000 (22:40 +0200)
server/trivabble-server.js

index a07fafea2fb65cf94fed4ecd68216b6e5ed4713a..8a68a870c22d1c1656f52d6ebce0e519340fda15 100644 (file)
@@ -556,7 +556,7 @@ function handleCommand(cmdNumber, message, response) {
                 case "rack":
                     rack = game.getPlayerRack(playerName);
 
-                    if (cmd.indexFrom > 6 || cmd.indexFrom < 0) {
+                    if (cmd.indexFrom > rackLength - 1 || cmd.indexFrom < 0) {
                         reply(message, response, cmdNumber, {error: 1, reason: "Wrong indexFrom"});
                         return false;
                     }
@@ -601,7 +601,7 @@ function handleCommand(cmdNumber, message, response) {
 
             switch (cmd.to) {
                 case "rack":
-                    if (cmd.indexTo < 0 || cmd.indexTo > 6) {
+                    if (cmd.indexTo < 0 || cmd.indexTo > rackLength - 1) {
                         reply(message, response, cmdNumber, {error: 1, reason: "Wrong indexTo"});
                         return false;
                     }