code comparison optimization

[compress.git] / compress.c

diff --git a/compress.c b/compress.c
index ea65038032707bf22d3ea6396221d19cba6ab0ef..f92393a47102e56e227cdfd9b2d6a86a4c9c3f5c 100644 (file)
--- a/compress.c
+++ b/compress.c
@@ -1,6 +1,6 @@
 /* depend: */
 /* cflags: */
-/* linker: atoi.o code.o debug.o fprintf.o */
+/* linker: atoi.o code.o debug.o fdprintf.o */
 
 #include <fcntl.h>
 #include <unistd.h>
@@ -8,7 +8,7 @@
 #include "atoi.h"
 #include "code.h"
 #include "debug.h"
-#include "fprintf.h"
+#include "fdprintf.h"
 
 /* constants */
 
@@ -17,6 +17,10 @@
 #define COMPRESS 1
 #define DECOMPRESS 2
 
+#ifndef O_RAW
+#define O_RAW 0
+#endif /* O_RAW */
+
 /* macros */
 
 /* gobal variables */
@@ -27,8 +31,7 @@ char *progname = NULL;
 
 int usage (int ret)
 {
-    //int fd = ret ? STDERR_FILENO : STDOUT_FILENO;
-    int fd = ret ? _fderr : _fdout;
+    int fd = ret ? stdfderr : stdfdout;
     fdprintf (fd, "usage: %s\n", progname);
     fdprintf (fd, " -h : help message\n");
     fdprintf (fd, " -i <file>: input file\n");
@@ -38,14 +41,8 @@ int usage (int ret)
     return ret;
 }
 
-void blkcpy (void *dst, const void *src, int len)
-{
-    while (len--) {
-        *((char *)dst++) = *((char *)src++);
-    }
-}
-
 /* create occurence table */
+
 int *create_table (char *filename)
 {
     byte_t buffer[BUFFER_SIZE] = {0};
@@ -58,7 +55,7 @@ int *create_table (char *filename)
     /* open file */
     fid = open (filename, O_RDONLY|O_RAW);
     if (fid == -1) {
-        VERBOSE (ERROR, PRINTERR ("can't open file '%s'\n", filename/);
+        VERBOSE (ERROR, PRINTERR ("can't open file '%s'\n", filename));
         return NULL;
     }
     VERBOSE (INFO, PRINTOUT ("file '%s' opened\n", filename));
@@ -97,7 +94,7 @@ void print_occ_table (int *table)
 
 leaf_t **init_forest (int *table)
 {
-    static leaf_t *leafs[NB_BYTES] = {0};
+    static leaf_t *leafs[NB_BYTES + 1] = {0};
     int nb_leafs = 0;
     int i, l;
 
@@ -363,7 +360,7 @@ int write_compress (char *output, char *input, code_t *codes, byte_t *header)
     char bits[(NB_BYTES - 1) + 8 + 1] = {0};
     int fin, fout;
     int length = 0;
-    int i, j, nbread;
+    int i, j, nbread, nbwrite;
     byte_t *pt;
 
     VERBOSE (DEBUG, PRINTOUT ("start writting compressed file\n"));
@@ -388,7 +385,14 @@ int write_compress (char *output, char *input, code_t *codes, byte_t *header)
     /* write header */
     length = (header[3] << 8) + header[4];
     VERBOSE (DEBUG, PRINTOUT ("lengh: %d\n", length));
-    write (fout, header, length + 6);
+    nbwrite = write (fout, header, length + 6);
+    if (nbwrite != length + 6) {
+        VERBOSE (ERROR, PRINTERR ("can't write %d bytes in file '%s'\n", length + 6 - nbwrite, output));
+           close (fout);
+           close (fin);
+        return 1;
+    }
+
 
     /* write file */
     pt = bufout;
@@ -405,7 +409,13 @@ int write_compress (char *output, char *input, code_t *codes, byte_t *header)
                 }
                 codcpy (bits, sizeof (code_t), bits + 8);
                 if (pt - bufout == BUFFER_SIZE - 1) {
-                    write (fout, bufout, BUFFER_SIZE);
+                    nbwrite = write (fout, bufout, BUFFER_SIZE);
+                    if (nbwrite != BUFFER_SIZE) {
+                        VERBOSE (ERROR, PRINTERR ("can't write %d bytes in file '%s'\n", BUFFER_SIZE - nbwrite, output));
+                           close (fout);
+                           close (fin);
+                        return 1;
+                    }
                     pt = bufout;
                 } else {
                     pt++;
@@ -428,7 +438,13 @@ int write_compress (char *output, char *input, code_t *codes, byte_t *header)
     }
     if (pt != bufout) {
         VERBOSE (DEBUG, PRINTOUT ("last partial buffer written: %u\n", pt - bufout));
-        write (fout, bufout, pt - bufout);
+        nbwrite = write (fout, bufout, pt - bufout);
+        if (nbwrite != pt - bufout) {
+            VERBOSE (ERROR, PRINTERR ("can't write %d bytes in file '%s'\n", pt - bufout - nbwrite, output));
+               close (fout);
+               close (fin);
+            return 1;
+        }
     }
     
     /* closing */
@@ -546,7 +562,7 @@ int write_decompress (char *output, char *input, code_t *codes)
     byte_t bufhea[MAX(NB_BYTES * (NB_BYTES - 1) / 2 / 8 + NB_BYTES + 6, BUFFER_SIZE)] = {0};
     char bits[(NB_BYTES - 1) + 1] = {0};
     int fin, fout;
-    int i, j, k, nb, size, rem;
+    int i, j, k, nb, size, nbwrite, rem;
     int is_found;
     int l = 0;
     byte_t *pt;
@@ -584,7 +600,7 @@ int write_decompress (char *output, char *input, code_t *codes)
     if (fout == -1) {
         VERBOSE (ERROR, PRINTERR ("can't open file '%s' for writing\n", output));
         close (fin);
-       return 2;
+           return 1;
     }
     VERBOSE (INFO, PRINTOUT ("file '%s' opened\n", output));
 
@@ -609,7 +625,13 @@ int write_decompress (char *output, char *input, code_t *codes)
                         bits[0] = 0;
                         if (pt - bufout == BUFFER_SIZE - 1) {
                             VERBOSE (DEBUG, PRINTOUT ("nb buffer out: %u\n", (pt - bufout)));
-                            write (fout, bufout, BUFFER_SIZE);
+                            nbwrite = write (fout, bufout, BUFFER_SIZE);
+                            if (nbwrite != BUFFER_SIZE) {
+                                VERBOSE (ERROR, PRINTERR ("can't write %d bytes in file '%s'\n'", BUFFER_SIZE - nbwrite, output));
+                                close (fout);
+                                close (fin);
+                                return 1;
+                            }
                             pt = bufout;
                         } else {
                             pt++;
@@ -625,7 +647,13 @@ int write_decompress (char *output, char *input, code_t *codes)
     }
     if (pt != bufout) {
         VERBOSE (DEBUG, PRINTOUT ("nb buffer out: %u\n", (pt - bufout)));
-        write (fout, bufout, pt - bufout);
+        nbwrite = write (fout, bufout, pt - bufout);
+        if (nbwrite != pt - bufout) {
+            VERBOSE (ERROR, PRINTERR ("can't write %d bytes in file '%s'\n'", pt - bufout - nbwrite, output));
+            close (fout);
+            close (fin);
+            return 1;
+        }
     }
 
     /* close files */
@@ -685,7 +713,7 @@ int main (int argc, char *argv[])
                 PRINTERR ("%s: missing verbose level\n", progname);
                 return usage (1);
             }
-            verbose = myatoi (arg);
+            verbose = atoi (arg);
             VERBOSE (INFO, PRINTOUT ("verbose: %d\n", verbose));
             break;
         case 'h':
@@ -732,10 +760,14 @@ int main (int argc, char *argv[])
 // test: compress.exe -h | awk '/usage:/ { rc=1 } END { exit (1-rc) }'
 // test: compress.exe -_ 2> /dev/null | awk 'END { if (NR == 0) { exit(0) } else exit (1) }'
 // test: compress.exe -_ 2>&1 | awk '/usage:/ { rc=1 } END { exit (1-rc) }'
+// test: compress.exe -v 2>&1 | grep -q 'missing verbose level'
+// test: compress.exe -c -i compress.c 2>&1 | grep -q 'missing file'
+// test: compress.exe -c -v 4 -i compress.c -o compress.mz | grep -q "Occurence table"
 // test: compress.exe -c -i compress.c -o compress.mz
 // test: ls -sS1 compress.c compress.mz | tail -1 | grep compress.mz
 // test: compress.exe -d -i compress.mz -o tmp.c
-// test: cmp compress.c tmp.c
-// test: rm compress.mz tmp.c
+// test: cmp compress.c tmp.c; x=$?; rm compress.mz tmp.c; test x$x = x0
+// test: compress.exe -c -i test/compress.c -o compress.mz 2>&1 | grep "can't open file"
+// test: compress.exe -c -i compress.c -o test/compress.mz 2>&1 | grep "can't open file"
 
 /* vim: set ts=4 sw=4 et: */